Implement 'osnadmin channel info' subcommand and update tests #4890 #4919
Conversation
Priyansurout
changed the title
There was a problem hiding this comment.
@Priyansurout Thank you for the updates.
I found some parts that needed correction, so I have added some suggestion comments in the relevant places. Please check them.
Additionally, I could not find the updates to the test code mentioned in the PR title. This PR might still be in draft status, and the updates may be added later, but I wanted to bring this to your attention just in case.
|
|
||
| Here are some examples of the `osnadmin channel info` command. | ||
|
|
||
| - Using the `--channel-id` flag to get detailed information for mychannel from the orderer at `orderer.example.com:9443`. |
There was a problem hiding this comment.
| - Using the `--channel-id` flag to get detailed information for mychannel from the orderer at `orderer.example.com:9443`. | |
| - Using the `--channelID` flag to get detailed information for mychannel from the orderer at `orderer.example.com:9443`. |
| "name": "mychannel", | ||
| "url": "/participation/v1/channels/mychannel", | ||
| "consensusRelation": "consenter", | ||
| "status": "active", | ||
| "height": 3 |
There was a problem hiding this comment.
| "name": "mychannel", | |
| "url": "/participation/v1/channels/mychannel", | |
| "consensusRelation": "consenter", | |
| "status": "active", | |
| "height": 3 | |
| "name": "mychannel", | |
| "url": "/participation/v1/channels/mychannel", | |
| "consensusRelation": "consenter", | |
| "status": "active", | |
| "height": 3 |
Co-authored-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com> Signed-off-by: Priyansu rout <65958054+Priyansurout@users.noreply.github.com>
Co-authored-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com> Signed-off-by: Priyansu rout <65958054+Priyansurout@users.noreply.github.com>
|
All of the commits must be signed to pass DCO check. Better yet, a pull request with a single feature should ideally be delivered as a single commit. See the instructions on how to squash multiple commits into a single commit for this pull request, and how to amend commits in future pull requests - https://hyperledger-fabric.readthedocs.io/en/latest/github/github.html#updating-a-pull-request |
|
What is the motivation for this change? all the info about a channel can be retrieved with:
All that is added is another method in the cli:
which is completely equivalent to the existing:
as they both emit the same GET request. So what is the point? Am I missing something here? |
| @@ -114,10 +117,12 @@ func executeForArgs(args []string) (output string, exit int, err error) { | |||
| resp, err = osnadmin.Join(osnURL, marshaledConfigBlock, caCertPool, tlsClientCert) | |||
| case list.FullCommand(): | |||
| if *listChannelID != "" { | |||
| resp, err = osnadmin.ListSingleChannel(osnURL, *listChannelID, caCertPool, tlsClientCert) | |||
| resp, err = osnadmin.Info(osnURL, *listChannelID, caCertPool, tlsClientCert) | |||
There was a problem hiding this comment.
So now we have two ways of getting the same information about a channel. Why do we need that?
Renaming the existing API is not a good idea as it might break existing tools that use the current CLI.
Implemented the osnadmin channel info subcommand to retrieve detailed information about a specific channel from an Ordering Service Node (OSN). This involved modifying the CLI commands and adding corresponding functionality to interact with the channel participation API.
Type of change
New feature
Implemented the osnadmin channel info subcommand to retrieve detailed information about a specific channel from an Ordering Service Node (OSN).
Introduced info subcommand under osnadmin channel to support querying individual channel details.
Updated existing tests and added new tests to cover the new feature and edge cases.